[GitHub] [flink] azagrebin commented on pull request #12110: [FLINK-17652][config] Legacy JM heap options should fallback to new JVM_HEAP_MEMORY in standalone

2020-05-14 Thread GitBox
azagrebin commented on pull request #12110: URL: https://github.com/apache/flink/pull/12110#issuecomment-628654517 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] azagrebin commented on pull request #12110: [FLINK-17652][config] Legacy JM heap options should fallback to new JVM_HEAP_MEMORY in standalone

2020-05-14 Thread GitBox
azagrebin commented on pull request #12110: URL: https://github.com/apache/flink/pull/12110#issuecomment-628439125 Thanks for the reviews @xintongsong @tillrohrmann. I refactored `BashJavaUtils` to make it easier to write unit tests because it would be more complicated to extend

[GitHub] [flink] azagrebin commented on pull request #12110: [FLINK-17652][config] Legacy JM heap options should fallback to new JVM_HEAP_MEMORY in standalone

2020-05-14 Thread GitBox
azagrebin commented on pull request #12110: URL: https://github.com/apache/flink/pull/12110#issuecomment-628437630 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message,