baisui1981 commented on PR #17521:
URL: https://github.com/apache/flink/pull/17521#issuecomment-1125592407
@RocMarshal @zentol @AHeise could you please give me some suggestion ,how to
continue processing for this PR?
--
This is an automated message from the Apache Git Service.
To respond
baisui1981 commented on PR #17521:
URL: https://github.com/apache/flink/pull/17521#issuecomment-1124451883
@RocMarshal @zentol @AHeise could you please give me some suggestion ,how to
continue processing for this PR?
--
This is an automated message from the Apache Git Service.
To respond
baisui1981 commented on PR #17521:
URL: https://github.com/apache/flink/pull/17521#issuecomment-1120122341
@RocMarshal @zentol @AHeise could you please give me some suggestion ,how to
continue processing for this PR?
--
This is an automated message from the Apache Git Service.
To respond
baisui1981 commented on PR #17521:
URL: https://github.com/apache/flink/pull/17521#issuecomment-1113989824
@RocMarshal @zentol @AHeise could you please give me some suggestion ,how to
continue processing for this PR?
--
This is an automated message from the Apache Git Service.
To respond
baisui1981 commented on PR #17521:
URL: https://github.com/apache/flink/pull/17521#issuecomment-1096292743
@RocMarshal @zentol @AHeise PTAL thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
baisui1981 commented on PR #17521:
URL: https://github.com/apache/flink/pull/17521#issuecomment-1091725602
@RocMarshal @zentol @AHeise PTAL thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
baisui1981 commented on pull request #17521:
URL: https://github.com/apache/flink/pull/17521#issuecomment-1082593810
@RocMarshal @zentol @AHeise PTAL thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
baisui1981 commented on pull request #17521:
URL: https://github.com/apache/flink/pull/17521#issuecomment-93858
I have make the fixes done,thanks for your reviews @RocMarshal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
baisui1981 commented on pull request #17521:
URL: https://github.com/apache/flink/pull/17521#issuecomment-997794130
> @baisui1981 Thanks for the update. Please run `mvn spotless:apply` in the
flink root directory for fixing the checkstyle. In my limited read, would you
mind introducing
baisui1981 commented on pull request #17521:
URL: https://github.com/apache/flink/pull/17521#issuecomment-997793461
> Thanks for the update.
thanks for your remind，I will add some test cases for the change.
--
This is an automated message from the Apache Git Service.
To respond to
baisui1981 commented on pull request #17521:
URL: https://github.com/apache/flink/pull/17521#issuecomment-986148674
> Hi, @baisui1981 , Would you mind checking the CI result
'src/main/java/org/apache/flink/runtime/execution/librarycache/ClassLoaderFactoryBuilder.java:[22,8]
(imports)
baisui1981 commented on pull request #17521:
URL: https://github.com/apache/flink/pull/17521#issuecomment-963767164
> I'm sorry, but that implementation sounds really unsafe and will only work
for the simplest of use-cases. Let's say you have 2 of your plugin jars that
both bundle the
baisui1981 commented on pull request #17521:
URL: https://github.com/apache/flink/pull/17521#issuecomment-955134599
@zentol @AHeise Thanks to both of you, have already understood me and have
understood what I want to express,
We want to build a product similar to
baisui1981 commented on pull request #17521:
URL: https://github.com/apache/flink/pull/17521#issuecomment-955126616
> But the user-jar is the same for all tasks. You can't use a manifest in
said jar for differentiating which classes should now be loaded / made
accessible. You either a)
baisui1981 commented on pull request #17521:
URL: https://github.com/apache/flink/pull/17521#issuecomment-953619514
> I don't think it is a good idea to give users direct access to this part
of the code. It just yet again increases the API surface, and for some _very_
important internal
baisui1981 commented on pull request #17521:
URL: https://github.com/apache/flink/pull/17521#issuecomment-950471796
@AHeise , thanks for your reply , by checking of git histories commit logs
, Maybe this issue is belong to `Command Line Client` more appropriate.
@kl0u could you help me
baisui1981 commented on pull request #17521:
URL: https://github.com/apache/flink/pull/17521#issuecomment-950471638
@AHeise , thanks for your reply , by checking of git histories commit logs
, Maybe this issue is belong to `Command Line Client` more appropriate.
@kl0u could you help me
baisui1981 commented on pull request #17521:
URL: https://github.com/apache/flink/pull/17521#issuecomment-947244756
> checkstyle failed. You can run `mvn spotless:apply` to fix it.
i have fix it
--
This is an automated message from the Apache Git Service.
To respond to the
18 matches
Mail list logo
