[GitHub] [flink] becketqin commented on pull request #12122: [FLINK-15102] Add continuousSource() method to StreamExecutionEnvironment.

2020-05-17 Thread GitBox
becketqin commented on pull request #12122: URL: https://github.com/apache/flink/pull/12122#issuecomment-629900169 Merged to master. 7abced6d7253845270e555f044fd2db774a54e3d This is an automated message from the Apache

[GitHub] [flink] becketqin commented on pull request #12122: [FLINK-15102] Add continuousSource() method to StreamExecutionEnvironment.

2020-05-17 Thread GitBox
becketqin commented on pull request #12122: URL: https://github.com/apache/flink/pull/12122#issuecomment-629811821 @StephanEwen Sorry for the back and forth, after second thought, I feel it might makes sense to put the `instanceOf CoordinatedOperatorFactory` in `StreamNode` instead of in

[GitHub] [flink] becketqin commented on pull request #12122: [FLINK-15102] Add continuousSource() method to StreamExecutionEnvironment.

2020-05-17 Thread GitBox
becketqin commented on pull request #12122: URL: https://github.com/apache/flink/pull/12122#issuecomment-629789714 @TsReaper I am fixing the compilation error. It was because a recent commit changed the interface of SourceOperator. From what I understand, all the operators will be

[GitHub] [flink] becketqin commented on pull request #12122: [FLINK-15102] Add continuousSource() method to StreamExecutionEnvironment.

2020-05-16 Thread GitBox
becketqin commented on pull request #12122: URL: https://github.com/apache/flink/pull/12122#issuecomment-629739829 Thanks @StephanEwen. Apologies that I somehow missed some of your previous comments... I'll merge the patch with the following changes. 1. `SourceReader`

[GitHub] [flink] becketqin commented on pull request #12122: [FLINK-15102] Add continuousSource() method to StreamExecutionEnvironment.

2020-05-15 Thread GitBox
becketqin commented on pull request #12122: URL: https://github.com/apache/flink/pull/12122#issuecomment-629142490 @StephanEwen Thanks for the review and suggestions. While I was addressing the comments, I realized that a class of `CoordinatedOperatorTransformation` may not be the best