[GitHub] [flink] carp84 commented on a change in pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

carp84 commented on a change in pull request #12144: URL: https://github.com/apache/flink/pull/12144#discussion_r435046468 ## File path: flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/util/HBaseConfigurationUtil.java ## @@ -22,20 +22,85

[GitHub] [flink] carp84 commented on a change in pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

carp84 commented on a change in pull request #12144: URL: https://github.com/apache/flink/pull/12144#discussion_r434597698 ## File path: flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/util/HBaseConfigurationUtil.java ## @@ -22,20 +22,85

[GitHub] [flink] carp84 commented on a change in pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

carp84 commented on a change in pull request #12144: URL: https://github.com/apache/flink/pull/12144#discussion_r434560352 ## File path: flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/util/HBaseConfigLoadingTest.java ## @@ -0,0 +1,177 @@