carp84 opened a new pull request #10300: [FLINK-14926] [state backends] Make sure no resource leak of RocksObject URL: https://github.com/apache/flink/pull/10300 ## What is the purpose of the change Introduce a `RocksDBOptionsContainer` to make sure all RocksDB options are created, recorded, and properly freed. ## Brief change log * Introduce a new `RocksDBOptionsContainer` class to encapsulate `PredefinedOptions` and `OptionsFactory`, as well as recording all `DBOptions` and `ColumnFamilyOptions` produced in runtime. * Close the `RocksDBOptionsContainer` instance whenever the RocksDB backend is `disposed` or error occurred during checkpoint restore or backend building process. * Change `PredefinedOptions` to implement `AutoClosable` interface. * Add a default `close` method in `OptionsFactory` for necessary clean up. ## Verifying this change This change added tests and can be verified as follows: - Added a new `RocksDBOptionsContainerTest` test case for the newly introduced class. - Verify all existing tests, including all tests in `flink-statebackend-rocksdb` module, `HAQueryableStateRocksDBBackendITCase`, `NonHAQueryableStateRocksDBBackendITCase` and `LocalRecoveryITCase` could pass. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
