[GitHub] [flink] chucheng92 commented on pull request #19654: [FLINK-27529][connector/common] Replace HybridSourceSplitEnumerator readerSourceIndex to safely Integer check

2022-10-12 Thread GitBox
chucheng92 commented on PR #19654: URL: https://github.com/apache/flink/pull/19654#issuecomment-1275852912 > @chucheng92 can you add a unit test? maybe that would clarify what the underlying problem is. pls see the IDEA screenshot. i think we need to change to equals method instead of '

[GitHub] [flink] chucheng92 commented on pull request #19654: [FLINK-27529][connector/common] Replace HybridSourceSplitEnumerator readerSourceIndex to safely Integer check

2022-06-08 Thread GitBox
chucheng92 commented on PR #19654: URL: https://github.com/apache/flink/pull/19654#issuecomment-1149715814 cc @tweise what do you think? can we need to fix this or won't fix now ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [flink] chucheng92 commented on pull request #19654: [FLINK-27529][connector/common] Replace HybridSourceSplitEnumerator readerSourceIndex to safely Integer check

2022-05-09 Thread GitBox
chucheng92 commented on PR #19654: URL: https://github.com/apache/flink/pull/19654#issuecomment-1120757526 @tweise Thanks for reviewing. And sorry i haven’t illustrate details clearly. Question-1: actual problem is == with Integer for readerIndex comparison. ``` Integer i

[GitHub] [flink] chucheng92 commented on pull request #19654: [FLINK-27529][connector/common] Replace HybridSourceSplitEnumerator readerSourceIndex to safely Integer check

2022-05-08 Thread GitBox
chucheng92 commented on PR #19654: URL: https://github.com/apache/flink/pull/19654#issuecomment-1120574881 > Thanks for reviewing. And sorry i haven’t illustrate details. Question-1: actual problem is == with Integer for readerIndex comparison. ``` Integer i1 = 128;

[GitHub] [flink] chucheng92 commented on pull request #19654: [FLINK-27529][connector/common] Replace HybridSourceSplitEnumerator readerSourceIndex to safely Integer check

2022-05-06 Thread GitBox
chucheng92 commented on PR #19654: URL: https://github.com/apache/flink/pull/19654#issuecomment-1120124506 @tweise Hi, tweise can u help me to reviewing this pr ? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] chucheng92 commented on pull request #19654: [FLINK-27529][connector/common] Replace HybridSourceSplitEnumerator readerSourceIndex to safely Integer check

2022-05-06 Thread GitBox
chucheng92 commented on PR #19654: URL: https://github.com/apache/flink/pull/19654#issuecomment-1120124033 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment