[GitHub] [flink] chucheng92 commented on pull request #22179: [FLINK-31380][table] FLIP-297: Support enhanced show catalogs syntax

2023-07-04 Thread via GitHub
chucheng92 commented on PR #22179: URL: https://github.com/apache/flink/pull/22179#issuecomment-1619594892 @wuchong hi, Jark. Another PR [ShowFunctions](https://github.com/apache/flink/pull/22903) has been merged, I picked some common logics and rebased mater, can u help to review this PR?

[GitHub] [flink] chucheng92 commented on pull request #22179: [FLINK-31380][table] FLIP-297: Support enhanced show catalogs syntax

2023-04-02 Thread via GitHub
chucheng92 commented on PR #22179: URL: https://github.com/apache/flink/pull/22179#issuecomment-1493592946 @Aitozi Sorry to pin you, all your comments have been addressed, can you help to re-check it ? thanks. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] chucheng92 commented on pull request #22179: [FLINK-31380][table] FLIP-297: Support enhanced show catalogs syntax

2023-03-30 Thread via GitHub
chucheng92 commented on PR #22179: URL: https://github.com/apache/flink/pull/22179#issuecomment-1490131776 @wuchong @Aitozi hi, guys. sorry to bother you, can you help to re-check it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] chucheng92 commented on pull request #22179: [FLINK-31380][table] FLIP-297: Support enhanced show catalogs syntax

2023-03-21 Thread via GitHub
chucheng92 commented on PR #22179: URL: https://github.com/apache/flink/pull/22179#issuecomment-1478871413 > Hi @chucheng92 , #22215 has been merged, could you rebase this pull request? Yes. i have rebased it. PTAL. -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] chucheng92 commented on pull request #22179: [FLINK-31380][table] FLIP-297: Support enhanced show catalogs syntax

2023-03-18 Thread via GitHub
chucheng92 commented on PR #22179: URL: https://github.com/apache/flink/pull/22179#issuecomment-1474829928 @Aitozi hi, Considering using a SupportLike parent class may make confused, i have changed and rebased the code. thanks for reviewing. -- This is an automated message from the

[GitHub] [flink] chucheng92 commented on pull request #22179: [FLINK-31380][table] FLIP-297: Support enhanced show catalogs syntax

2023-03-17 Thread via GitHub
chucheng92 commented on PR #22179: URL: https://github.com/apache/flink/pull/22179#issuecomment-1474659993 because execution of operation has changed in [FLINK-31507](https://issues.apache.org/jira/browse/FLINK-31507) . I will rebase it. -- This is an automated message from the Apache

[GitHub] [flink] chucheng92 commented on pull request #22179: [FLINK-31380][table] FLIP-297: Support enhanced show catalogs syntax

2023-03-16 Thread via GitHub
chucheng92 commented on PR #22179: URL: https://github.com/apache/flink/pull/22179#issuecomment-1473088287 > @wuchong hi, jark. I added a lot of test cases and did integration testing for a while. Can u help me to review this feature? cc @wuchong PTAL~ -- This is an automated