[GitHub] [flink] crazyzhou commented on pull request #14890: [FLINK-21178][Runtime/Checkpointing] Task failure should trigger master hook's reset()

2021-03-02 Thread GitBox
crazyzhou commented on pull request #14890: URL: https://github.com/apache/flink/pull/14890#issuecomment-789410205 > I have reverted this commit to make master can compile. Please open another PR to fix the conflicts. Sorry for not rebasing master, I can raise another one based on la

[GitHub] [flink] crazyzhou commented on pull request #14890: [FLINK-21178][Runtime/Checkpointing] Task failure should trigger master hook's reset()

2021-03-01 Thread GitBox
crazyzhou commented on pull request #14890: URL: https://github.com/apache/flink/pull/14890#issuecomment-788638526 > @crazyzhou Thanks for the patch. It looks that the unit test has format issue that failed the CI. Can you fix that. Otherwise the patch LGTM. @becketqin I have fixed t

[GitHub] [flink] crazyzhou commented on pull request #14890: [FLINK-21178][Runtime/Checkpointing] Task failure should trigger master hook's reset()

2021-02-28 Thread GitBox
crazyzhou commented on pull request #14890: URL: https://github.com/apache/flink/pull/14890#issuecomment-787648466 @StephanEwen @becketqin Can you assign this Flink jira ticket to me and are there any more concerns about this pull request? If we are fine about this, can we merge it now and

[GitHub] [flink] crazyzhou commented on pull request #14890: [FLINK-21178][Runtime/Checkpointing] Task failure should trigger master hook's reset()

2021-02-21 Thread GitBox
crazyzhou commented on pull request #14890: URL: https://github.com/apache/flink/pull/14890#issuecomment-783110723 Hi Stephan, sorry for the late reply for our holiday. > * Do Pravega setups always configure "ALL" as the failover strategy? We use the default `region`, it's the