[GitHub] [flink] curcur commented on pull request #16685: [FLINK-23279][tests] Randomly use Changelog Backend in tests

2021-08-06 Thread GitBox
curcur commented on pull request #16685: URL: https://github.com/apache/flink/pull/16685#issuecomment-894094497 Please make sure addresing confilicts before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] curcur commented on pull request #16685: [FLINK-23279][tests] Randomly use Changelog Backend in tests

2021-08-06 Thread GitBox
curcur commented on pull request #16685: URL: https://github.com/apache/flink/pull/16685#issuecomment-894093949 I do not further concerns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] curcur commented on pull request #16685: [FLINK-23279][tests] Randomly use Changelog Backend in tests

2021-08-03 Thread GitBox
curcur commented on pull request #16685: URL: https://github.com/apache/flink/pull/16685#issuecomment-892362947 LGTM overall, thanks @rkhachatryan for enabling the tests! Please take a look at my inline comments. Also, before accepting it, 1. We should run the test with `flag =