[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-01-28 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r566133368 ## File path: flink-end-to-end-tests/flink-glue-schema-registry-test/pom.xml ## @@ -0,0 +1,150 @@ + + +http://maven.apache.org/POM/4.0.0"; +

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-11 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r574341163 ## File path: flink-formats/flink-avro-glue-schema-registry/pom.xml ## @@ -0,0 +1,99 @@ + + +http://maven.apache.org/POM/4.0.0"; +xml

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-11 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r574342605 ## File path: flink-formats/flink-avro-glue-schema-registry/src/main/java/org/apache/flink/formats/avro/glue/schema/registry/GlueSchemaRegistryInputStreamDe

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-11 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r574343844 ## File path: flink-formats/flink-avro-glue-schema-registry/src/test/java/org/apache/flink/formats/avro/glue/schema/registry/GlueSchemaRegistryAvroSchemaCod

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-11 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r574345802 ## File path: flink-formats/flink-avro-glue-schema-registry/src/main/java/org/apache/flink/formats/avro/glue/schema/registry/GlueSchemaRegistryAvroSerializa

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-11 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r574346915 ## File path: flink-formats/flink-avro-glue-schema-registry/pom.xml ## @@ -0,0 +1,99 @@ + + +http://maven.apache.org/POM/4.0.0"; +xml

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-12 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r575091145 ## File path: flink-formats/flink-avro-glue-schema-registry/pom.xml ## @@ -0,0 +1,99 @@ + + +http://maven.apache.org/POM/4.0.0"; +xml

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-16 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r576978089 ## File path: flink-end-to-end-tests/test-scripts/test_glue_schema_registry.sh ## @@ -0,0 +1,72 @@ +#!/usr/bin/env bash Review comment: Have

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-17 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r577638986 ## File path: flink-end-to-end-tests/flink-glue-schema-registry-test/src/main/java/org/apache/flink/glue/schema/registry/test/GSRKinesisPubsubClient.java ##

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-17 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r577985579 ## File path: flink-end-to-end-tests/flink-glue-schema-registry-test/pom.xml ## @@ -0,0 +1,252 @@ + + +http://maven.apache.org/POM/4.0.0"; +

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-17 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r577986479 ## File path: flink-formats/flink-avro-glue-schema-registry/pom.xml ## @@ -0,0 +1,99 @@ + + +http://maven.apache.org/POM/4.0.0"; +xml

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-17 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r577987171 ## File path: flink-formats/flink-avro-glue-schema-registry/src/main/java/org/apache/flink/formats/avro/glue/schema/registry/GlueSchemaRegistryAvroSchemaCod

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-18 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r578255800 ## File path: flink-formats/flink-avro-glue-schema-registry/src/main/java/org/apache/flink/formats/avro/glue/schema/registry/GlueSchemaRegistryAvroSchemaCod

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-18 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r578256434 ## File path: flink-formats/flink-avro-glue-schema-registry/src/main/java/org/apache/flink/formats/avro/glue/schema/registry/GlueSchemaRegistryAvroSchemaCod

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-18 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r578805957 ## File path: flink-end-to-end-tests/test-scripts/test_glue_schema_registry.sh ## @@ -0,0 +1,72 @@ +#!/usr/bin/env bash Review comment: @Liny

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-26 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r583535654 ## File path: flink-end-to-end-tests/test-scripts/test_glue_schema_registry.sh ## @@ -0,0 +1,78 @@ +#!/usr/bin/env bash +

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-26 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r583545398 ## File path: flink-end-to-end-tests/flink-glue-schema-registry-test/pom.xml ## @@ -0,0 +1,259 @@ + + +http://maven.apache.org/POM/4.0.0"; +

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-26 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r583546283 ## File path: flink-formats/flink-avro-glue-schema-registry/src/main/java/org/apache/flink/formats/avro/glue/schema/registry/GlueSchemaRegistryAvroSchemaCod

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-26 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r583652106 ## File path: flink-end-to-end-tests/test-scripts/test_glue_schema_registry.sh ## @@ -0,0 +1,78 @@ +#!/usr/bin/env bash +

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-03-01 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r585024774 ## File path: flink-end-to-end-tests/test-scripts/test_glue_schema_registry.sh ## @@ -0,0 +1,78 @@ +#!/usr/bin/env bash +

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-03-04 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r587263383 ## File path: flink-formats/flink-avro-glue-schema-registry/pom.xml ## @@ -0,0 +1,99 @@ + + +http://maven.apache.org/POM/4.0.0"; +xml

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-03-15 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r594371070 ## File path: flink-end-to-end-tests/test-scripts/common.sh ## @@ -364,6 +364,7 @@ function check_logs_for_errors { | grep -v "HeapDumpOnOutOf

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-03-15 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r594496214 ## File path: flink-end-to-end-tests/test-scripts/common.sh ## @@ -364,6 +364,7 @@ function check_logs_for_errors { | grep -v "HeapDumpOnOutOf