[GitHub] [flink] dannycranmer commented on a change in pull request #18733: [FLINK-26064][connectors/firehose,kinesis] Using own event loop group…

2022-02-15 Thread GitBox
dannycranmer commented on a change in pull request #18733: URL: https://github.com/apache/flink/pull/18733#discussion_r806704643 ## File path: flink-connectors/flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AWSGeneralUtil.java ## @@ -273,7 +274,15 @

[GitHub] [flink] dannycranmer commented on a change in pull request #18733: [FLINK-26064][connectors/firehose,kinesis] Using own event loop group…

2022-02-15 Thread GitBox
dannycranmer commented on a change in pull request #18733: URL: https://github.com/apache/flink/pull/18733#discussion_r806704643 ## File path: flink-connectors/flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AWSGeneralUtil.java ## @@ -273,7 +274,15 @

[GitHub] [flink] dannycranmer commented on a change in pull request #18733: [FLINK-26064][connectors/firehose,kinesis] Using own event loop group…

2022-02-15 Thread GitBox
dannycranmer commented on a change in pull request #18733: URL: https://github.com/apache/flink/pull/18733#discussion_r806704643 ## File path: flink-connectors/flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AWSGeneralUtil.java ## @@ -273,7 +274,15 @

[GitHub] [flink] dannycranmer commented on a change in pull request #18733: [FLINK-26064][connectors/firehose,kinesis] Using own event loop group…

2022-02-15 Thread GitBox
dannycranmer commented on a change in pull request #18733: URL: https://github.com/apache/flink/pull/18733#discussion_r806704643 ## File path: flink-connectors/flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AWSGeneralUtil.java ## @@ -273,7 +274,15 @

[GitHub] [flink] dannycranmer commented on a change in pull request #18733: [FLINK-26064][connectors/firehose,kinesis] Using own event loop group…

2022-02-14 Thread GitBox
dannycranmer commented on a change in pull request #18733: URL: https://github.com/apache/flink/pull/18733#discussion_r805832727 ## File path: flink-connectors/flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AWSGeneralUtil.java ## @@ -273,7 +274,15 @

[GitHub] [flink] dannycranmer commented on a change in pull request #18733: [FLINK-26064][connectors/firehose,kinesis] Using own event loop group…

2022-02-12 Thread GitBox
dannycranmer commented on a change in pull request #18733: URL: https://github.com/apache/flink/pull/18733#discussion_r805143370 ## File path: flink-connectors/flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AWSGeneralUtil.java ## @@ -274,6 +275,7 @@

[GitHub] [flink] dannycranmer commented on a change in pull request #18733: [FLINK-26064][connectors/firehose,kinesis] Using own event loop group…

2022-02-11 Thread GitBox
dannycranmer commented on a change in pull request #18733: URL: https://github.com/apache/flink/pull/18733#discussion_r804883389 ## File path: flink-connectors/flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AWSGeneralUtil.java ## @@ -273,7 +274,15 @

[GitHub] [flink] dannycranmer commented on a change in pull request #18733: [FLINK-26064][connectors/firehose,kinesis] Using own event loop group…

2022-02-11 Thread GitBox
dannycranmer commented on a change in pull request #18733: URL: https://github.com/apache/flink/pull/18733#discussion_r804879289 ## File path: flink-connectors/flink-connector-aws-base/src/test/java/org/apache/flink/connector/aws/util/SdkEventLoopGroupBuilder.java ## @@ -0,0 +