dawidwys commented on a change in pull request #10431: [FLINK-15067][table]
Pass configuration to the underlying ExecutionEnvironment from TableEnvironment
URL: https://github.com/apache/flink/pull/10431#discussion_r354218042
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java
##########
@@ -757,7 +757,7 @@ else if (configOption.hasFallbackKeys()) {
}
@Override
- public <T> WritableConfig set(ConfigOption<T> option, T value) {
+ public <T> Configuration set(ConfigOption<T> option, T value) {
Review comment:
I wouldn't call it a workaround, but yes :)
It is so that we can just inline the instantiation and setting like:
```
public void addConfiguration(Configuration config);
addConfiguration(
new Configuration()
.set(...)
.set(...)
.set(...)
)
```
Without this change it would have to be:
```
Configuration config = new Configuration();
config
.set(...)
.set(...)
.set(...)
addConfiguration(config)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
