[GitHub] [flink] dawidwys commented on a change in pull request #12147: [FLINK-17653] FLIP-126: Unify (and separate) Watermark Assigners

dawidwys commented on a change in pull request #12147: URL: https://github.com/apache/flink/pull/12147#discussion_r425081822 ## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java ## @@ -2

[GitHub] [flink] dawidwys commented on a change in pull request #12147: [FLINK-17653] FLIP-126: Unify (and separate) Watermark Assigners

dawidwys commented on a change in pull request #12147: URL: https://github.com/apache/flink/pull/12147#discussion_r425126049 ## File path: flink-core/src/main/java/org/apache/flink/api/common/eventtime/WatermarkOutputMultiplexer.java ## @@ -0,0 +1,266 @@ +/* + * Licensed to th

[GitHub] [flink] dawidwys commented on a change in pull request #12147: [FLINK-17653] FLIP-126: Unify (and separate) Watermark Assigners

dawidwys commented on a change in pull request #12147: URL: https://github.com/apache/flink/pull/12147#discussion_r425131321 ## File path: flink-core/src/main/java/org/apache/flink/api/common/eventtime/WatermarkStrategies.java ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apach

[GitHub] [flink] dawidwys commented on a change in pull request #12147: [FLINK-17653] FLIP-126: Unify (and separate) Watermark Assigners

dawidwys commented on a change in pull request #12147: URL: https://github.com/apache/flink/pull/12147#discussion_r425145921 ## File path: flink-core/src/test/java/org/apache/flink/api/common/eventtime/WatermarkMatchers.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache S

[GitHub] [flink] dawidwys commented on a change in pull request #12147: [FLINK-17653] FLIP-126: Unify (and separate) Watermark Assigners

dawidwys commented on a change in pull request #12147: URL: https://github.com/apache/flink/pull/12147#discussion_r425197840 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java ## @@ -910,40 +930,25 @@ public ExecutionConf

[GitHub] [flink] dawidwys commented on a change in pull request #12147: [FLINK-17653] FLIP-126: Unify (and separate) Watermark Assigners

dawidwys commented on a change in pull request #12147: URL: https://github.com/apache/flink/pull/12147#discussion_r425205009 ## File path: flink-core/src/test/java/org/apache/flink/api/common/eventtime/WatermarkStrategiesTest.java ## @@ -0,0 +1,101 @@ +/* + * Licensed to the A

[GitHub] [flink] dawidwys commented on a change in pull request #12147: [FLINK-17653] FLIP-126: Unify (and separate) Watermark Assigners

dawidwys commented on a change in pull request #12147: URL: https://github.com/apache/flink/pull/12147#discussion_r425830145 ## File path: flink-core/src/main/java/org/apache/flink/api/common/eventtime/WatermarkOutputMultiplexer.java ## @@ -0,0 +1,266 @@ +/* + * Licensed to th

[GitHub] [flink] dawidwys commented on a change in pull request #12147: [FLINK-17653] FLIP-126: Unify (and separate) Watermark Assigners

dawidwys commented on a change in pull request #12147: URL: https://github.com/apache/flink/pull/12147#discussion_r425835304 ## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java ## @@

[GitHub] [flink] dawidwys commented on a change in pull request #12147: [FLINK-17653] FLIP-126: Unify (and separate) Watermark Assigners

dawidwys commented on a change in pull request #12147: URL: https://github.com/apache/flink/pull/12147#discussion_r425840701 ## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java ## @@

[GitHub] [flink] dawidwys commented on a change in pull request #12147: [FLINK-17653] FLIP-126: Unify (and separate) Watermark Assigners

dawidwys commented on a change in pull request #12147: URL: https://github.com/apache/flink/pull/12147#discussion_r425840831 ## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java ## @@

[GitHub] [flink] dawidwys commented on a change in pull request #12147: [FLINK-17653] FLIP-126: Unify (and separate) Watermark Assigners

dawidwys commented on a change in pull request #12147: URL: https://github.com/apache/flink/pull/12147#discussion_r425845726 ## File path: flink-core/src/main/java/org/apache/flink/api/common/eventtime/TimestampAssignerSupplier.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to the

[GitHub] [flink] dawidwys commented on a change in pull request #12147: [FLINK-17653] FLIP-126: Unify (and separate) Watermark Assigners

dawidwys commented on a change in pull request #12147: URL: https://github.com/apache/flink/pull/12147#discussion_r425848001 ## File path: flink-core/src/main/java/org/apache/flink/api/common/eventtime/WatermarkStrategies.java ## @@ -0,0 +1,251 @@ +/* + * Licensed to the Apach

[GitHub] [flink] dawidwys commented on a change in pull request #12147: [FLINK-17653] FLIP-126: Unify (and separate) Watermark Assigners

dawidwys commented on a change in pull request #12147: URL: https://github.com/apache/flink/pull/12147#discussion_r425850966 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/TimestampsAndWatermarksOperator.java ## @@ -0,0 +1,174 @@