[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-25 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338922440 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnviro

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-25 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338925343 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/module/ModuleMa

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-25 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338925099 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/module/ModuleMa

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-25 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338924795 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/module/ModuleMa

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-25 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338924122 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnviro

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-25 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338924299 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/module/ModuleMa

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-25 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338922440 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnviro

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-24 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338623814 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/module/ModuleMa

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-24 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338623814 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/module/ModuleMa

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-24 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338455510 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/module/ModuleMa

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-24 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338462061 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/module/ModuleMa

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-24 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338457726 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/module/ModuleMa

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-24 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338460945 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/module/exceptions

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-24 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338455474 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/module/ModuleMa

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-24 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338461768 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/module/ModuleMa

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-24 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338449603 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnviro

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-24 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338460858 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/module/exceptions

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-24 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338449473 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnviro

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-24 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338451184 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/module/ModuleMa

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-24 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338446800 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnviro

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-24 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338446486 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnviro

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-24 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338446486 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnviro

[GitHub] [flink] dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager

2019-10-24 Thread GitBox
dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add Module interface and ModuleManager URL: https://github.com/apache/flink/pull/9937#discussion_r338446056 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/java