[GitHub] [flink] dawidwys commented on pull request #13050: [FLINK-18750][table] SqlValidatorException thrown when select from a …

2020-08-25 Thread GitBox
dawidwys commented on pull request #13050: URL: https://github.com/apache/flink/pull/13050#issuecomment-679895722 Thanks for the update. LGTM This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] dawidwys commented on pull request #13050: [FLINK-18750][table] SqlValidatorException thrown when select from a …

2020-08-05 Thread GitBox
dawidwys commented on pull request #13050: URL: https://github.com/apache/flink/pull/13050#issuecomment-669008809 To emphasize it again though, personally if we don't want to upgrade calcite, personally I am fine with that change.

[GitHub] [flink] dawidwys commented on pull request #13050: [FLINK-18750][table] SqlValidatorException thrown when select from a …

2020-08-05 Thread GitBox
dawidwys commented on pull request #13050: URL: https://github.com/apache/flink/pull/13050#issuecomment-669007993 > If we have a simple workaround for a quick fix(log an issue there and remove the code when upgrade), it is better than just wait for the upgrade. I mostly agree. I am

[GitHub] [flink] dawidwys commented on pull request #13050: [FLINK-18750][table] SqlValidatorException thrown when select from a …

2020-08-03 Thread GitBox
dawidwys commented on pull request #13050: URL: https://github.com/apache/flink/pull/13050#issuecomment-668164712 Are we planning to bump Calcite version for 1.12? @wuchong @twalthr If we do, I'd prefer we do not add this workaround. If we don't the PR looks good to me