[GitHub] [flink] dianfu commented on a diff in pull request #20029: [FLINK-27392][cep] CEP Pattern supports definition of the maximum time gap between events

2022-06-27 Thread GitBox
dianfu commented on code in PR #20029: URL: https://github.com/apache/flink/pull/20029#discussion_r907935649 ## flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Quantifier.java: ## @@ -187,15 +190,17 @@ public enum ConsumingStrategy { public static class

[GitHub] [flink] dianfu commented on a diff in pull request #20029: [FLINK-27392][cep] CEP Pattern supports definition of the maximum time gap between events

2022-06-27 Thread GitBox
dianfu commented on code in PR #20029: URL: https://github.com/apache/flink/pull/20029#discussion_r906937708 ## flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Pattern.java: ## @@ -579,6 +662,21 @@ private void checkIfPreviousPatternGreedy() { }

[GitHub] [flink] dianfu commented on a diff in pull request #20029: [FLINK-27392][cep] CEP Pattern supports definition of the maximum time gap between events

2022-06-27 Thread GitBox
dianfu commented on code in PR #20029: URL: https://github.com/apache/flink/pull/20029#discussion_r906937708 ## flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Pattern.java: ## @@ -579,6 +662,21 @@ private void checkIfPreviousPatternGreedy() { }

[GitHub] [flink] dianfu commented on a diff in pull request #20029: [FLINK-27392][cep] CEP Pattern supports definition of the maximum time gap between events

2022-06-22 Thread GitBox
dianfu commented on code in PR #20029: URL: https://github.com/apache/flink/pull/20029#discussion_r904446329 ## flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Pattern.java: ## @@ -579,6 +662,16 @@ private void checkIfPreviousPatternGreedy() { }