[GitHub] [flink] dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API

dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API URL: https://github.com/apache/flink/pull/8532#issuecomment-501319227 @tillrohrmann I agree that client based submission can meet most requirements, while I guess there may be also use

[GitHub] [flink] dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API

dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API URL: https://github.com/apache/flink/pull/8532#issuecomment-500851018 @sunjincheng121 I think packaging the dependencies into the zip file makes much sense to me. I have updated the PR

[GitHub] [flink] dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API

dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API URL: https://github.com/apache/flink/pull/8532#issuecomment-500670192 @sunjincheng121 Have updated the PR according to your comments. Looking forwarding to your feedback.

[GitHub] [flink] dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API

dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API URL: https://github.com/apache/flink/pull/8532#issuecomment-500445263 @sunjincheng121 Thanks a lot for the review. Regarding to question 1, it's to ensure better backwards compat

[GitHub] [flink] dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API

dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API URL: https://github.com/apache/flink/pull/8532#issuecomment-499334823 @tillrohrmann Thanks a lot for the remind and have addressed the test failure. --

[GitHub] [flink] dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API

dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API URL: https://github.com/apache/flink/pull/8532#issuecomment-498644520 @zentol @tillrohrmann I have updated the PR and separated the newly added API with the old ones per @zentol 's sug

[GitHub] [flink] dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API

dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API URL: https://github.com/apache/flink/pull/8532#issuecomment-498612766 @zentol The manual test does not include the third commit. Definitely agree that separating the new API with the o

[GitHub] [flink] dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API

dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API URL: https://github.com/apache/flink/pull/8532#issuecomment-498608458 @zentol I think your suggestions make sense to me. Will updated the PR accordingly. Thanks a lot. ---

[GitHub] [flink] dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API

dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API URL: https://github.com/apache/flink/pull/8532#issuecomment-498607304 @tillrohrmann Thanks a lot for your reply. As mentioned by @sunjincheng121 that the test case RestAPIStabilityTes

[GitHub] [flink] dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API

dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API URL: https://github.com/apache/flink/pull/8532#issuecomment-496409121 @sunjincheng121 Great, I have rebased the PR. Thi