[GitHub] [flink] dianfu commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script

2019-06-19 Thread GitBox
dianfu commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script URL: https://github.com/apache/flink/pull/8609#issuecomment-503478165 @knaufk Thanks a lot for the hotfix. The fix makes sense to me. --

[GitHub] [flink] dianfu commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script

2019-06-12 Thread GitBox
dianfu commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script URL: https://github.com/apache/flink/pull/8609#issuecomment-50131 @tillrohrmann Thanks a lot for your comments. I have updated the PR and addressed one of your concerns. Regard

[GitHub] [flink] dianfu commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script

2019-06-11 Thread GitBox
dianfu commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script URL: https://github.com/apache/flink/pull/8609#issuecomment-501092870 @sunjincheng121 Make sense to me as `--opt-jars` is not a must have option. Considering that the table JAR wil

[GitHub] [flink] dianfu commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script

2019-06-10 Thread GitBox
dianfu commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script URL: https://github.com/apache/flink/pull/8609#issuecomment-500671784 @tillrohrmann @sunjincheng121 I have updated the PR and the changes are only related to the build script for P

[GitHub] [flink] dianfu commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script

2019-06-09 Thread GitBox
dianfu commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script URL: https://github.com/apache/flink/pull/8609#issuecomment-500295981 @tillrohrmann Thanks a lot for your review. Your suggestion makes much sense to me. I have created a dedica