[GitHub] [flink] echauchot commented on pull request #14558: [FLINK-18685] [runtime] Make MiniClusterJobClient#getAccumulators non-blocking in Streaming mode

2021-01-27 Thread GitBox
echauchot commented on pull request #14558: URL: https://github.com/apache/flink/pull/14558#issuecomment-768297169 @rmetzger don't worry, I know what it is :) This is an automated message from the Apache Git Service. To respo

[GitHub] [flink] echauchot commented on pull request #14558: [FLINK-18685] [runtime] Make MiniClusterJobClient#getAccumulators non-blocking in Streaming mode

2021-01-27 Thread GitBox
echauchot commented on pull request #14558: URL: https://github.com/apache/flink/pull/14558#issuecomment-768224928 @tillrohrmann can you please take a look at this PR as I saw you in the git history of this part of code ? Thanks

[GitHub] [flink] echauchot commented on pull request #14558: [FLINK-18685] [runtime] Make MiniClusterJobClient#getAccumulators non-blocking in Streaming mode

2021-01-22 Thread GitBox
echauchot commented on pull request #14558: URL: https://github.com/apache/flink/pull/14558#issuecomment-765397114 Friendly ping: @rmetzger do you have time to review/merge this PR? if not, can you ping someone to look ? Thanks.

[GitHub] [flink] echauchot commented on pull request #14558: [FLINK-18685] [runtime] Make MiniClusterJobClient#getAccumulators non-blocking in Streaming mode

2021-01-14 Thread GitBox
echauchot commented on pull request #14558: URL: https://github.com/apache/flink/pull/14558#issuecomment-760141274 @rmetzger this PR is ready for review PTAL. This is an automated message from the Apache Git Service. To respo

[GitHub] [flink] echauchot commented on pull request #14558: [FLINK-18685] [runtime] Make MiniClusterJobClient#getAccumulators non-blocking in Streaming mode

2021-01-14 Thread GitBox
echauchot commented on pull request #14558: URL: https://github.com/apache/flink/pull/14558#issuecomment-760135401 @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [flink] echauchot commented on pull request #14558: [FLINK-18685] [runtime] Make MiniClusterJobClient#getAccumulators non-blocking in Streaming mode

2021-01-14 Thread GitBox
echauchot commented on pull request #14558: URL: https://github.com/apache/flink/pull/14558#issuecomment-760131077 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [flink] echauchot commented on pull request #14558: [FLINK-18685] [runtime] Make MiniClusterJobClient#getAccumulators non-blocking in Streaming mode

2021-01-14 Thread GitBox
echauchot commented on pull request #14558: URL: https://github.com/apache/flink/pull/14558#issuecomment-760130203 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [flink] echauchot commented on pull request #14558: [FLINK-18685] [runtime] Make MiniClusterJobClient#getAccumulators non-blocking in Streaming mode

2021-01-14 Thread GitBox
echauchot commented on pull request #14558: URL: https://github.com/apache/flink/pull/14558#issuecomment-760129111 > > @rmetzger I fixed one of the failing tests. But for _UnalignedCheckpointCompatibilityITCase_ savepoint tests, I know we need to get the accumulators from _JobExecutionResu

[GitHub] [flink] echauchot commented on pull request #14558: [FLINK-18685] [runtime] Make MiniClusterJobClient#getAccumulators non-blocking in Streaming mode

2021-01-09 Thread GitBox
echauchot commented on pull request #14558: URL: https://github.com/apache/flink/pull/14558#issuecomment-756811406 @rmetzger I fixed one of the failing tests. But for _UnalignedCheckpointCompatibilityITCase_ I know we need to get the accumulators from _JobExecutionResult_ it that case for

[GitHub] [flink] echauchot commented on pull request #14558: [FLINK-18685] [runtime] Make MiniClusterJobClient#getAccumulators non-blocking in Streaming mode

2021-01-08 Thread GitBox
echauchot commented on pull request #14558: URL: https://github.com/apache/flink/pull/14558#issuecomment-756811406 @rmetzger I fixed one of the failing tests. But for _UnalignedCheckpointCompatibilityITCase_ I know we need to get the accumulators from _JobExecutionResult_ it that case for

[GitHub] [flink] echauchot commented on pull request #14558: [FLINK-18685] [runtime] Make MiniClusterJobClient#getAccumulators non-blocking in Streaming mode

2021-01-06 Thread GitBox
echauchot commented on pull request #14558: URL: https://github.com/apache/flink/pull/14558#issuecomment-755259773 @rmetzger I'm fixing the tests. But I have a flink starter question: how can I check if a given job is a streaming job ? Because if so I need to get the accumulators from job

[GitHub] [flink] echauchot commented on pull request #14558: [FLINK-18685] [runtime] Make MiniClusterJobClient#getAccumulators non-blocking in Streaming mode

2021-01-05 Thread GitBox
echauchot commented on pull request #14558: URL: https://github.com/apache/flink/pull/14558#issuecomment-754744583 R:@rmetzger. There are some test failures that I missed during my local tests. I'll ping you when this PR is ready for review. ---