[GitHub] [flink] echauchot commented on pull request #14961: [FLINK-21388] [flink-parquet] support DECIMAL parquet logical type when parquet primitive type is INT32

2021-02-18 Thread GitBox
echauchot commented on pull request #14961: URL: https://github.com/apache/flink/pull/14961#issuecomment-781272437 @HuangZhenQiu can you ping a committer as you proposed to review this PR ? Thanks This is an automated mess

[GitHub] [flink] echauchot commented on pull request #14961: [FLINK-21388] [flink-parquet] support DECIMAL parquet logical type when parquet primitive type is INT32

2021-02-18 Thread GitBox
echauchot commented on pull request #14961: URL: https://github.com/apache/flink/pull/14961#issuecomment-781322363 @fhueske as you merged the previous related PR, can you please review this one ? Thanks. This is an automa

[GitHub] [flink] echauchot commented on pull request #14961: [FLINK-21388] [flink-parquet] support DECIMAL parquet logical type when parquet primitive type is INT32

2021-02-19 Thread GitBox
echauchot commented on pull request #14961: URL: https://github.com/apache/flink/pull/14961#issuecomment-781967279 @HuangZhenQiu to be honest I still have a doubt on the whole parquet support for DECIMAL. parquet [doc](https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#de

[GitHub] [flink] echauchot commented on pull request #14961: [FLINK-21388] [flink-parquet] support DECIMAL parquet logical type when parquet primitive type is INT32

2021-03-11 Thread GitBox
echauchot commented on pull request #14961: URL: https://github.com/apache/flink/pull/14961#issuecomment-796853393 @JingsongLi WDYT ? This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] echauchot commented on pull request #14961: [FLINK-21388] [flink-parquet] support DECIMAL parquet logical type when parquet primitive type is INT32

2021-03-12 Thread GitBox
echauchot commented on pull request #14961: URL: https://github.com/apache/flink/pull/14961#issuecomment-797328765 > Are you worried about the decimal point? In fact, int32 or Int64 contains integer and decimal parts, so precision and data will not be lost. You can take a look at Java's `B