[GitHub] [flink] echauchot commented on pull request #17839: [FLINK-24859] document new connectors formats

2021-12-03 Thread GitBox
echauchot commented on pull request #17839: URL: https://github.com/apache/flink/pull/17839#issuecomment-985298945 Thanks for merging @AHeise ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [flink] echauchot commented on pull request #17839: [FLINK-24859] document new connectors formats

2021-12-01 Thread GitBox
echauchot commented on pull request #17839: URL: https://github.com/apache/flink/pull/17839#issuecomment-983457016 @MartijnVisser thanks for your review ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] echauchot commented on pull request #17839: [FLINK-24859] document new connectors formats

2021-11-30 Thread GitBox
echauchot commented on pull request #17839: URL: https://github.com/apache/flink/pull/17839#issuecomment-982771435 @MartijnVisser thanks for your review once again! I addressed your comments and resolved the related discussions. For your questions I answered and left discussions open for y

[GitHub] [flink] echauchot commented on pull request #17839: [FLINK-24859] document new connectors formats

2021-11-30 Thread GitBox
echauchot commented on pull request #17839: URL: https://github.com/apache/flink/pull/17839#issuecomment-982664038 @MartijnVisser @AHeise do you agree with my commit that renames formats to make the name coherent ? It would be a breaking change as they were already released. But yet, they

[GitHub] [flink] echauchot commented on pull request #17839: [FLINK-24859] document new connectors formats

2021-11-30 Thread GitBox
echauchot commented on pull request #17839: URL: https://github.com/apache/flink/pull/17839#issuecomment-982660548 @AHeise once this PR is merged, I'll backport it to 1.14 as for the other PR. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [flink] echauchot commented on pull request #17839: [FLINK-24859] document new connectors formats

2021-11-30 Thread GitBox
echauchot commented on pull request #17839: URL: https://github.com/apache/flink/pull/17839#issuecomment-982638487 @MartijnVisser rebased on master. And applying your comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] echauchot commented on pull request #17839: [FLINK-24859] document new connectors formats

2021-11-24 Thread GitBox
echauchot commented on pull request #17839: URL: https://github.com/apache/flink/pull/17839#issuecomment-977688776 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [flink] echauchot commented on pull request #17839: [FLINK-24859] document new connectors formats

2021-11-24 Thread GitBox
echauchot commented on pull request #17839: URL: https://github.com/apache/flink/pull/17839#issuecomment-977688038 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [flink] echauchot commented on pull request #17839: [FLINK-24859] document new connectors formats

2021-11-23 Thread GitBox
echauchot commented on pull request #17839: URL: https://github.com/apache/flink/pull/17839#issuecomment-976603434 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [flink] echauchot commented on pull request #17839: [FLINK-24859] document new connectors formats

2021-11-22 Thread GitBox
echauchot commented on pull request #17839: URL: https://github.com/apache/flink/pull/17839#issuecomment-975422921 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [flink] echauchot commented on pull request #17839: [FLINK-24859] document new connectors formats

2021-11-22 Thread GitBox
echauchot commented on pull request #17839: URL: https://github.com/apache/flink/pull/17839#issuecomment-975325103 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [flink] echauchot commented on pull request #17839: [FLINK-24859] document new connectors formats

2021-11-22 Thread GitBox
echauchot commented on pull request #17839: URL: https://github.com/apache/flink/pull/17839#issuecomment-975283584 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [flink] echauchot commented on pull request #17839: [FLINK-24859] document new connectors formats

2021-11-19 Thread GitBox
echauchot commented on pull request #17839: URL: https://github.com/apache/flink/pull/17839#issuecomment-974135466 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi