fapaul commented on a change in pull request #18996:
URL: https://github.com/apache/flink/pull/18996#discussion_r822573821
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/SinkMetricsITCase.java
##########
@@ -147,7 +147,7 @@ private void assertSinkMetrics(
*
MetricWriter.RECORD_SIZE_IN_BYTES)));
// MetricWriter is just incrementing errors every even record
assertThat(
- metrics.get(MetricNames.NUM_RECORDS_OUT_ERRORS),
+ metrics.get(MetricNames.NUM_RECORDS_SEND_ERRORS),
Review comment:
Nit: Since you only deprecated the old metric it probably makes sense to
also verify the deprecated metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
