[GitHub] [flink] fpompermaier commented on pull request #11906: [FLINK-17356][jdbc][postgres] Support PK and Unique constraints

2020-05-20 Thread GitBox
fpompermaier commented on pull request #11906: URL: https://github.com/apache/flink/pull/11906#issuecomment-631659010 @wuchong do you have an idea of why the testGroupByInsert is failing? This is an automated message from the

[GitHub] [flink] fpompermaier commented on pull request #11906: [FLINK-17356][jdbc][postgres] Support PK and Unique constraints

2020-05-19 Thread GitBox
fpompermaier commented on pull request #11906: URL: https://github.com/apache/flink/pull/11906#issuecomment-630830688 I addressed your comments, now the PR should be ok This is an automated message from the Apache Git Service

[GitHub] [flink] fpompermaier commented on pull request #11906: [FLINK-17356][jdbc][postgres] Support PK and Unique constraints

2020-04-29 Thread GitBox
fpompermaier commented on pull request #11906: URL: https://github.com/apache/flink/pull/11906#issuecomment-621282562 What about moving getUniqueConstraints() and getPrimaryKey() in a more general class? They can probably be reused by other catalogs..of course we have to decide if builtinS

[GitHub] [flink] fpompermaier commented on pull request #11906: [FLINK-17356][jdbc][postgres] Support PK and Unique constraints

2020-04-26 Thread GitBox
fpompermaier commented on pull request #11906: URL: https://github.com/apache/flink/pull/11906#issuecomment-619541776 actually the git comment of 9d527f9 should link to FLINK-17385.. sorry for the mistake This is an automate