[GitHub] [flink] fredia commented on a diff in pull request #22457: [FLINK-31876][QS] Migrate flink-queryable-state-runtime tests to JUnit5

2023-05-08 Thread via GitHub
fredia commented on code in PR #22457: URL: https://github.com/apache/flink/pull/22457#discussion_r1188095891 ## flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/KvStateClientHandlerTest.java: ## @@ -93,28 +92,66 @@ public

[GitHub] [flink] fredia commented on a diff in pull request #22457: [FLINK-31876][QS] Migrate flink-queryable-state-runtime tests to JUnit5

2023-05-08 Thread via GitHub
fredia commented on code in PR #22457: URL: https://github.com/apache/flink/pull/22457#discussion_r1188095522 ## flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/NonHAQueryableStateFsBackendITCase.java: ## @@ -48,31 +48,33

[GitHub] [flink] fredia commented on a diff in pull request #22457: [FLINK-31876][QS] Migrate flink-queryable-state-runtime tests to JUnit5

2023-05-08 Thread via GitHub
fredia commented on code in PR #22457: URL: https://github.com/apache/flink/pull/22457#discussion_r1187186157 ## flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java: ## @@ -492,9 +493,7 @@

[GitHub] [flink] fredia commented on a diff in pull request #22457: [FLINK-31876][QS] Migrate flink-queryable-state-runtime tests to JUnit5

2023-05-08 Thread via GitHub
fredia commented on code in PR #22457: URL: https://github.com/apache/flink/pull/22457#discussion_r1187185813 ## flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/NonHAQueryableStateFsBackendITCase.java: ## @@ -48,31 +48,33

[GitHub] [flink] fredia commented on a diff in pull request #22457: [FLINK-31876][QS] Migrate flink-queryable-state-runtime tests to JUnit5

2023-05-08 Thread via GitHub
fredia commented on code in PR #22457: URL: https://github.com/apache/flink/pull/22457#discussion_r1187096060 ## flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/KvStateClientHandlerTest.java: ## @@ -93,28 +92,66 @@ public

[GitHub] [flink] fredia commented on a diff in pull request #22457: [FLINK-31876][QS] Migrate flink-queryable-state-runtime tests to JUnit5

2023-04-25 Thread via GitHub
fredia commented on code in PR #22457: URL: https://github.com/apache/flink/pull/22457#discussion_r1176516288 ## flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java: ## @@ -257,33 +258,34 @@ public void testRe