[GitHub] [flink] fredia commented on a diff in pull request #22772: [FLINK-19010][metric] Introduce subtask level restore metric

fredia commented on code in PR #22772: URL: https://github.com/apache/flink/pull/22772#discussion_r1268077347 ## docs/content/docs/ops/metrics.md: ## @@ -1343,6 +1343,11 @@ Note that for failed checkpoints, metrics are updated on a best efforts basis an The time in nanos

[GitHub] [flink] fredia commented on a diff in pull request #22772: [FLINK-19010][metric] Introduce subtask level restore metric

fredia commented on code in PR #22772: URL: https://github.com/apache/flink/pull/22772#discussion_r1268060700 ## flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskIOMetricGroup.java: ## @@ -128,6 +134,29 @@ public TaskIOMetricGroup(TaskMetricGroup parent) {

[GitHub] [flink] fredia commented on a diff in pull request #22772: [FLINK-19010][metric] Introduce subtask level restore metric

fredia commented on code in PR #22772: URL: https://github.com/apache/flink/pull/22772#discussion_r1268058951 ## flink-runtime/src/test/java/org/apache/flink/runtime/metrics/groups/TaskIOMetricGroupTest.java: ## @@ -95,6 +95,15 @@ void testTaskIOMetricGroup() throws InterruptedE

[GitHub] [flink] fredia commented on a diff in pull request #22772: [FLINK-19010][metric] Introduce subtask level restore metric

fredia commented on code in PR #22772: URL: https://github.com/apache/flink/pull/22772#discussion_r1265060501 ## flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskIOMetricGroup.java: ## @@ -67,10 +70,12 @@ public class TaskIOMetricGroup extends ProxyMetric

[GitHub] [flink] fredia commented on a diff in pull request #22772: [FLINK-19010][metric] Introduce subtask level restore metric

fredia commented on code in PR #22772: URL: https://github.com/apache/flink/pull/22772#discussion_r1260645282 ## flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskIOMetricGroup.java: ## @@ -67,10 +70,12 @@ public class TaskIOMetricGroup extends ProxyMetric

[GitHub] [flink] fredia commented on a diff in pull request #22772: [FLINK-19010][metric] Introduce subtask level restore metric

fredia commented on code in PR #22772: URL: https://github.com/apache/flink/pull/22772#discussion_r1236225638 ## flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskIOMetricGroup.java: ## @@ -196,6 +204,23 @@ public void markTaskStart() { this.taskSt

[GitHub] [flink] fredia commented on a diff in pull request #22772: [FLINK-19010][metric] Introduce subtask level restore metric

fredia commented on code in PR #22772: URL: https://github.com/apache/flink/pull/22772#discussion_r1236220893 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -695,6 +695,7 @@ void restoreInternal() throws Exception {

[GitHub] [flink] fredia commented on a diff in pull request #22772: [FLINK-19010][metric] Introduce subtask level restore metric

fredia commented on code in PR #22772: URL: https://github.com/apache/flink/pull/22772#discussion_r1236211241 ## flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskIOMetricGroup.java: ## @@ -67,10 +70,12 @@ public class TaskIOMetricGroup extends ProxyMetric