[GitHub] [flink] fredia commented on pull request #20091: [FLINK-27570][runtime] Fix initialize base locations for checkpoint

2022-07-03 Thread GitBox
fredia commented on PR #20091: URL: https://github.com/apache/flink/pull/20091#issuecomment-1173269329 @rkhachatryan could you please take a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [flink] fredia commented on pull request #20091: [FLINK-27570][runtime] Fix initialize base locations for checkpoint

2022-06-30 Thread GitBox
fredia commented on PR #20091: URL: https://github.com/apache/flink/pull/20091#issuecomment-1171930223 @JesseAtSZ Thanks for your explanation, `fileSystem.mkdirs()` not only returns `false` when the directory exists, but also returns `false` when there is no permission to write. This PR ma

[GitHub] [flink] fredia commented on pull request #20091: [FLINK-27570][runtime] Fix initialize base locations for checkpoint

2022-06-30 Thread GitBox
fredia commented on PR #20091: URL: https://github.com/apache/flink/pull/20091#issuecomment-1171898497 Thanks for creating this PR @JesseAtSZ. IIUC, you expect an IOException when the checkpoint directory exists(`fileSystem.mkdir()` return `false`)? I think it's a little wired, could yo