[GitHub] [flink] fsk119 commented on a diff in pull request #19846: [FLINK-27768][sql-gateway] Allow executing sql for the SqlGatewayService

2022-07-04 Thread GitBox
fsk119 commented on code in PR #19846: URL: https://github.com/apache/flink/pull/19846#discussion_r913336031 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java: ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apach

[GitHub] [flink] fsk119 commented on a diff in pull request #19846: [FLINK-27768][sql-gateway] Allow executing sql for the SqlGatewayService

2022-07-04 Thread GitBox
fsk119 commented on code in PR #19846: URL: https://github.com/apache/flink/pull/19846#discussion_r913338177 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java: ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apach

[GitHub] [flink] fsk119 commented on a diff in pull request #19846: [FLINK-27768][sql-gateway] Allow executing sql for the SqlGatewayService

2022-07-04 Thread GitBox
fsk119 commented on code in PR #19846: URL: https://github.com/apache/flink/pull/19846#discussion_r913345494 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/SqlGatewayServiceStatementITCase.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the

[GitHub] [flink] fsk119 commented on a diff in pull request #19846: [FLINK-27768][sql-gateway] Allow executing sql for the SqlGatewayService

2022-07-04 Thread GitBox
fsk119 commented on code in PR #19846: URL: https://github.com/apache/flink/pull/19846#discussion_r913350238 ## flink-table/flink-sql-gateway/src/test/resources/sql/insert.q: ## @@ -0,0 +1,182 @@ +# insert.q - insert Review Comment: Currently only `ADD JAR/REMOVE JAR/STATEME

[GitHub] [flink] fsk119 commented on a diff in pull request #19846: [FLINK-27768][sql-gateway] Allow executing sql for the SqlGatewayService

2022-07-04 Thread GitBox
fsk119 commented on code in PR #19846: URL: https://github.com/apache/flink/pull/19846#discussion_r913351720 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java: ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apach

[GitHub] [flink] fsk119 commented on a diff in pull request #19846: [FLINK-27768][sql-gateway] Allow executing sql for the SqlGatewayService

2022-07-04 Thread GitBox
fsk119 commented on code in PR #19846: URL: https://github.com/apache/flink/pull/19846#discussion_r913352482 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/result/ResultStore.java: ## @@ -37,6 +37,13 @@ public class ResultStore { pri

[GitHub] [flink] fsk119 commented on a diff in pull request #19846: [FLINK-27768][sql-gateway] Allow executing sql for the SqlGatewayService

2022-07-05 Thread GitBox
fsk119 commented on code in PR #19846: URL: https://github.com/apache/flink/pull/19846#discussion_r913501319 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/utils/SqlGatewayServiceExtension.java: ## @@ -43,6 +47,15 @@ public class SqlGateway

[GitHub] [flink] fsk119 commented on a diff in pull request #19846: [FLINK-27768][sql-gateway] Allow executing sql for the SqlGatewayService

2022-07-05 Thread GitBox
fsk119 commented on code in PR #19846: URL: https://github.com/apache/flink/pull/19846#discussion_r913520517 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java: ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apach

[GitHub] [flink] fsk119 commented on a diff in pull request #19846: [FLINK-27768][sql-gateway] Allow executing sql for the SqlGatewayService

2022-07-05 Thread GitBox
fsk119 commented on code in PR #19846: URL: https://github.com/apache/flink/pull/19846#discussion_r913713918 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/context/SessionContextTest.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache