[GitHub] [flink] fsk119 commented on a diff in pull request #20298: [FLINK-28152][sql-gateway][hive] Allow executing statement for the HiveServer2Endpoint

2022-07-27 Thread GitBox
fsk119 commented on code in PR #20298: URL: https://github.com/apache/flink/pull/20298#discussion_r931717886 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/endpoint/hive/util/ThriftObjectConversionsTest.java: ## @@ -34,4 +107,249 @@ public void

[GitHub] [flink] fsk119 commented on a diff in pull request #20298: [FLINK-28152][sql-gateway][hive] Allow executing statement for the HiveServer2Endpoint

2022-07-27 Thread GitBox
fsk119 commented on code in PR #20298: URL: https://github.com/apache/flink/pull/20298#discussion_r931088836 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/endpoint/hive/HiveServer2EndpointStatementITCase.java: ## @@ -0,0 +1,180 @@ +/* + *

[GitHub] [flink] fsk119 commented on a diff in pull request #20298: [FLINK-28152][sql-gateway][hive] Allow executing statement for the HiveServer2Endpoint

2022-07-27 Thread GitBox
fsk119 commented on code in PR #20298: URL: https://github.com/apache/flink/pull/20298#discussion_r931086928 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/endpoint/hive/HiveServer2EndpointStatementITCase.java: ## @@ -0,0 +1,180 @@ +/* + *

[GitHub] [flink] fsk119 commented on a diff in pull request #20298: [FLINK-28152][sql-gateway][hive] Allow executing statement for the HiveServer2Endpoint

2022-07-27 Thread GitBox
fsk119 commented on code in PR #20298: URL: https://github.com/apache/flink/pull/20298#discussion_r930961893 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/endpoint/hive/util/ThriftObjectConversions.java: ## @@ -18,28 +18,238 @@ package

[GitHub] [flink] fsk119 commented on a diff in pull request #20298: [FLINK-28152][sql-gateway][hive] Allow executing statement for the HiveServer2Endpoint

2022-07-26 Thread GitBox
fsk119 commented on code in PR #20298: URL: https://github.com/apache/flink/pull/20298#discussion_r930644202 ## flink-connectors/flink-connector-hive/src/test/resources/endpoint/hive_catalog.q: ## @@ -0,0 +1,121 @@ +# catalog_database.q - CREATE/DROP/SHOW/USE CATALOG/DATABASE

[GitHub] [flink] fsk119 commented on a diff in pull request #20298: [FLINK-28152][sql-gateway][hive] Allow executing statement for the HiveServer2Endpoint

2022-07-26 Thread GitBox
fsk119 commented on code in PR #20298: URL: https://github.com/apache/flink/pull/20298#discussion_r929604300 ## flink-table/flink-sql-gateway-api/src/main/java/org/apache/flink/table/gateway/api/SqlGatewayService.java: ## @@ -108,6 +120,16 @@ void closeOperation(SessionHandle

[GitHub] [flink] fsk119 commented on a diff in pull request #20298: [FLINK-28152][sql-gateway][hive] Allow executing statement for the HiveServer2Endpoint

2022-07-26 Thread GitBox
fsk119 commented on code in PR #20298: URL: https://github.com/apache/flink/pull/20298#discussion_r929567090 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/endpoint/hive/util/ThriftObjectConversions.java: ## @@ -51,25 +261,250 @@ public static