gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1125888070
> My only concern is around changes to the Mockito infrastructure (should be
a separate story) and addition of the new Mockito based tests.
> Would it be possible to avoid that?
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1125930126
As suggested I've created FLINK-27605.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1125967453
I've done the following steps and I think every suggestion is added:
* Squashed all the commits
* Added the last missing `@Nullable`s
* Changed the PR description to reflect
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1126051696
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1126125435
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1126192259
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1126477747
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1126687852
I've rebased the whole change to the top of the latest master. Maybe this
helps since other PRs are not suffering from this:
```
--2022-05-14 08:05:31--
http://security.ubunt
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1126717741
Finally w/ all the modifications tests passed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1128611123
@dmvk Thanks for the suggestions, I've applied them all:
* Added your latest suggestion as commit
* Squashed it into a single commit
* Added the following extra commit messag
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1128815905
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1134321938
@dmvk thanks for making the PR better and taking care!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1090006663
cc @mbalassi @dmvk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1090141243
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1090235882
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1090337233
Please be aware that I've started to test it on k8s but not yet finished:
https://gist.github.com/gaborgsomogyi/ac4f71ead8494da2f5c35265bcb1e885
--
This is an automated message fr
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1091146733
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1091623030
I've just finished the testing on minikube and here is the log which proves
that renewal happens successfully. Kerberos logging is also enabled to see the
details.
[dt.log](https
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1091623695
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1091638288
Just to mark the original source of this code it's basically coming from
Spark with some modifications:
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/sp
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1091893147
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1093068781
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1095061969
> The cluster entrypoint might be confusing for the user if hadoop is not
present on the classpath, because we print the missing hadoop warning on DEBUG
level.
What do you su
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1095077528
> Should the obtainDelegationTokens(Credentials credentials) be implemented?
Maybe it could be a shared code path for the renewal (the one time renewal that
is scheduled)?
No
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1097737082
Correct me if I'm wrong but AFAIK Flink must avoid breaking changes between
minor releases.
Having `true ` as default for `KERBEROS_FETCH_DELEGATION_TOKEN` may or may
not be good
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1097820808
> As long as this would be discussed on the mailing list, it should IMO be
ok-ish as it's a change to the configuration and doesn't break any APIs.
Good to know how customs wo
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1097927982
I've made all the changes, re-tested it on cluster and works. Please find
the log in attach.
[dt.log](https://github.com/apache/flink/files/8480947/dt.log)
--
This is an au
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1098003872
I've squashed everything into a single commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
gaborgsomogyi commented on PR #19372:
URL: https://github.com/apache/flink/pull/19372#issuecomment-1104866261
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
29 matches
Mail list logo
