[GitHub] [flink] gaoyunhaii commented on pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-25 Thread GitBox
gaoyunhaii commented on pull request #14740: URL: https://github.com/apache/flink/pull/14740#issuecomment-786327409 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] gaoyunhaii commented on pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-25 Thread GitBox
gaoyunhaii commented on pull request #14740: URL: https://github.com/apache/flink/pull/14740#issuecomment-785731866 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] gaoyunhaii commented on pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-18 Thread GitBox
gaoyunhaii commented on pull request #14740: URL: https://github.com/apache/flink/pull/14740#issuecomment-781798040 Hi Roman @rkhachatryan very thanks for the review! I updated the PR according to the comments~ This is an

[GitHub] [flink] gaoyunhaii commented on pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-17 Thread GitBox
gaoyunhaii commented on pull request #14740: URL: https://github.com/apache/flink/pull/14740#issuecomment-781124923 Hi Roman @rkhachatryan , I updated the PR according to the offline discussion: 1. Introduce the interface for `CheckpointPlanCalculator` for future extension. 2.

[GitHub] [flink] gaoyunhaii commented on pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-07 Thread GitBox
gaoyunhaii commented on pull request #14740: URL: https://github.com/apache/flink/pull/14740#issuecomment-774912042 Hi Roman @rkhachatryan, very thanks for the careful review, I updated the remaining issue with

[GitHub] [flink] gaoyunhaii commented on pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-05 Thread GitBox
gaoyunhaii commented on pull request #14740: URL: https://github.com/apache/flink/pull/14740#issuecomment-773782948 Hi Roman @rkhachatryan very thanks for the review! I have update the PR via https://github.com/apache/flink/pull/14740/commits/0a5a79498ab93134eccbe025489ede9aae233392

[GitHub] [flink] gaoyunhaii commented on pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-04 Thread GitBox
gaoyunhaii commented on pull request #14740: URL: https://github.com/apache/flink/pull/14740#issuecomment-773782948 Hi Roman @rkhachatryan very thanks for the review! I have update the PR via https://github.com/apache/flink/pull/14740/commits/0a5a79498ab93134eccbe025489ede9aae233392

[GitHub] [flink] gaoyunhaii commented on pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-02 Thread GitBox
gaoyunhaii commented on pull request #14740: URL: https://github.com/apache/flink/pull/14740#issuecomment-771480929 Hi @aljoscha I like the two patches for they make the calculation process much more clear. I have updated the PR according to the comments.

[GitHub] [flink] gaoyunhaii commented on pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-02 Thread GitBox
gaoyunhaii commented on pull request #14740: URL: https://github.com/apache/flink/pull/14740#issuecomment-771480929 Hi @aljoscha I like the two patches for they make the calculation process much more clear. I have updated the PR according to the comments.

[GitHub] [flink] gaoyunhaii commented on pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-01-30 Thread GitBox
gaoyunhaii commented on pull request #14740: URL: https://github.com/apache/flink/pull/14740#issuecomment-770215757 Very thanks @guoweiM for the comments and I have update the algorithm accordingly This is an automated