gm7y8 commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-718919467
@rmetzger I believe we should be good to merge. Thanks a lot @XComp,
@vthinkxie for your time and patience.
gm7y8 commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-718706391
@flinkbot run azure
This is an automated message from the Apache Git Service.
To respond to the message, please
gm7y8 commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-717796453
> Thanks @gm7y8 . Additionally, I verified manually that the changes result
in the expected behavior. Let's wait for @vthinkxie to get back to us to review
the code itself.
gm7y8 commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-717783238
@flinkbot run azure
This is an automated message from the Apache Git Service.
To respond to the message,
gm7y8 commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-715584720
@XComp @vthinkxie I have addressed the requested changes. Build also has
passed.
This is an automated message
gm7y8 commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-715456178
@XComp For some reason its failing in the HBase repo i retriggered the build
This is an automated message from
gm7y8 commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-715452694
@flinkbot run azure
This is an automated message from the Apache Git Service.
To respond to the message, please
gm7y8 commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-714289878
@XComp You are welcome! I have also verified fix with Word Count job
![Uploading Screen Shot 2020-10-22 at 12.23.01 AM.png…]()
gm7y8 commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-714249342
> > > @XComp I was able to identify the code fix. I working to unit test it
had some issue with Flink set up to start a job with checkpoint and savepoint.
it might take a day or
gm7y8 commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-714126117
@flinkbot approve description
This is an automated message from the Apache Git Service.
To respond to the
gm7y8 commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-714118740
> > @XComp I was able to identify the code fix. I working to unit test it
had some issue with Flink set up to start a job with checkpoint and savepoint.
it might take a day or so
gm7y8 commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-712711411
@XComp I was able to identify the code fix. I working to unit test it had
some issue with Flink set up to start a job with checkpoint and savepoint. it
might take a day or so as
gm7y8 commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-708157763
@AHeise sorry for the delay to respond back. it should simple fix in the UI
layer. I would take the opinion of @XComp @vthinkxie if it ok with the above
change.
gm7y8 commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-704014916
> Thanks for this improvement @gm7y8
> Overall, it looks good to me.
>
> @XComp @vthinkxie Did someone check that the change works in UI?
>
> I left comments about
gm7y8 commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-703980529
@XComp @azagrebin created to fix bug FLINK-19501 to fix the missing enum..
other PR just addresses only the html part not the snapshot document
gm7y8 commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-700174911
@XComp I have taken care of commit message and other formatting issues.
This is an automated message from the
gm7y8 commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-698158028
@flinkbot run azure
This is an automated message from the Apache Git Service.
To respond to the message, please
gm7y8 commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-698158028
@flinkbot run azure
This is an automated message from the Apache Git Service.
To respond to the message, please
gm7y8 commented on pull request #13458:
URL: https://github.com/apache/flink/pull/13458#issuecomment-697169263
@flinkbot run azure
This is an automated message from the Apache Git Service.
To respond to the message, please
19 matches
Mail list logo
