godfreyhe commented on pull request #12475: URL: https://github.com/apache/flink/pull/12475#issuecomment-638710775
@dawidwys For a long term, I think sql client should has an extended sql parser which can parse not not standard sql statement but also some special commands (e.g. `SOURCE`, `SET`, `REST`). which is also discussed in other prs. For now, some configs for both parser are different, such as: `SqlParserImplFactory`, `identifierMaxLength` (see: `PlannerContext#getSqlParserConfig` for blink planner and `PlanningConfigurationBuilder#getSqlParserConfig` for old planner). So it's also not clean that we copy those logic to sql client to build `org.apache.calcite.sql.parser.SqlParser`. As an interim solution, we use public interface `org.apache.flink.table.delegation.Parser` to parse a sql statement, which not only parse a statement but also validate the SqlNode (will initialize `DynamicTableSource`). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
