subject:"\[GitHub\] \[flink\] godfreyhe commented on pull request #17845\: \[FLINK\-24352\] \[flink\-table\-planner\] Add null check for temporal table check on SqlSnapshot"

[GitHub] [flink] godfreyhe commented on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-12-30 Thread GitBox

godfreyhe commented on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-1003247727 @YuvalItzchakov I add `assert ns.getTable() != null` before calling `ns.getTable().isTemporal()` and merge the pr. Thanks for the contribution -- This is an automated mess

[GitHub] [flink] godfreyhe commented on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-26 Thread GitBox

godfreyhe commented on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-979972238 @YuvalItzchakov Thanks for the contribution, I'm be fine with the current solution even it not very well, since we do not check whether the query in `with` is temporal (just l