godfreyhe opened a new pull request #13039:
URL: https://github.com/apache/flink/pull/13039


   
   ## What is the purpose of the change
   
   *sql client has a lot of logic to execute an insert job, which can be 
simplified through `executeSql` method. This pr aims to do the improvement*
   
   
   ## Brief change log
   
     - *remove `executeUpdate` method from Executor*
     - *execute insert statement through `executeSql` method in CliClient*
     - *remove the unused code*
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as 
LocalExecutorITCase.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / 
don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ **not documented**)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to