haishui126 commented on PR #22291:
URL: https://github.com/apache/flink/pull/22291#issuecomment-1498458381
> @haishui126 can we add a more meaningful commit message such as
"[FLINK-XYZ] Fix maxAllowedWatermark arithmetic overflow when the source is
idle" or something similar?
haishui126 commented on PR #22291:
URL: https://github.com/apache/flink/pull/22291#issuecomment-1491451371
> The change makes sense. Can you add a unit test to verify the regression
is fixed?
>
> I also think there needs to be another change to the
`shouldWaitForAlignment()` to not
haishui126 commented on PR #22291:
URL: https://github.com/apache/flink/pull/22291#issuecomment-1491418101
I have added a test base on
[FLINK-25982](https://issues.apache.org/jira/browse/FLINK-25982).
Is there anything else I need to do?
--
This is an automated message from the Apache
