[GitHub] [flink] huwh commented on a diff in pull request #22196: [FLINK-31445][runtime]Split resource allocate/release related logic from FineGrainedSlotManager to TaskManagerTracker

2023-03-21 Thread via GitHub
huwh commented on code in PR #22196: URL: https://github.com/apache/flink/pull/22196#discussion_r1143240702 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/ResourceDeclaration.java: ## @@ -51,7 +51,7 @@ public int getNumNeeded() {

[GitHub] [flink] huwh commented on a diff in pull request #22196: [FLINK-31445][runtime]Split resource allocate/release related logic from FineGrainedSlotManager to TaskManagerTracker

2023-03-20 Thread via GitHub
huwh commented on code in PR #22196: URL: https://github.com/apache/flink/pull/22196#discussion_r1142891394 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerRuntimeServices.java: ## @@ -83,7 +83,13 @@ private static SlotManager