huwh commented on PR #21233: URL: https://github.com/apache/flink/pull/21233#issuecomment-1323278177
> Thanks for reviewing, @xintongsong, i have updated this pr according to your suggestions 1. split a new issues to remove unused ResourceActions#notifyAllocationFailure in https://issues.apache.org/jira/browse/FLINK-30084. we need merge this PR at first, then i will rebase my changes in this pr. 3. rename the ResourceActions and ResourceNotEnoughNotifier 4. introduce new implementation of ResourceAllocator: NonSupportedResourceAllocatorImpl 5. move the ResourceManager#startNewWorker, releaseResource to ActiveResourceManager 4.1 ResourceManager#releaseResource For non-ActiveResourceManager logic is not used, we can assume that TaskMangers registered on SlotManager must have been registered on ResourceManager, and when TaskManager is unregistered from RM, it will also be unregistered from SlotManager -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
