kezhuw commented on pull request #15053: URL: https://github.com/apache/flink/pull/15053#issuecomment-789410967
Hi @rkhachatryan, I am a bit worry about whether the type `Optional<JobID>` is a right choice for reasons: * Most `getJobId` expect a not nullable `JobID`. * The only path `CollectionEnvironment`, `CollectionExecutor` could also be shaped to return a plan global job id(or created before execution if `Plan.jobId` is null). Due to `getJobId` is a brand new api, it does not hurt anyone. * After `DataSet` phased out, that only path will also be phased out. Then, it will be really confused that `getJobId` returns an optional value in that stage. cc @AHeise @aljoscha @StephanEwen ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
