kl0u commented on a change in pull request #9240: [FLINK-13440] Add test that fails job when in-flight sync savepoint is discarded. URL: https://github.com/apache/flink/pull/9240#discussion_r308610461
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java ########## @@ -581,10 +580,10 @@ public void enableCheckpointing( checkpointStatsTracker = checkNotNull(statsTracker, "CheckpointStatsTracker"); - CheckpointFailureManager failureManager = new CheckpointFailureManager(chkConfig.getTolerableCheckpointFailureNumber(), () -> - getJobMasterMainThreadExecutor().execute(() -> - failGlobal(new FlinkRuntimeException("Exceeded checkpoint tolerable failure threshold.")) - )); + CheckpointFailureManager failureManager = new CheckpointFailureManager( + chkConfig.getTolerableCheckpointFailureNumber(), + cause -> getJobMasterMainThreadExecutor().execute(() -> failGlobal(cause)) Review comment: The previous message is just moved "upwards" in the `CheckpointFailureManager.handleCheckpointException()`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services