[GitHub] [flink] kl0u commented on pull request #12132: [FLINK-17593][Connectors/FileSystem] Support arbitrary recovery mechanism for PartFileWriter

kl0u commented on pull request #12132: URL: https://github.com/apache/flink/pull/12132#issuecomment-630085068 No problem! Thanks for working on this @guoweiM ! This is an automated message from the Apache Git Service. To resp

[GitHub] [flink] kl0u commented on pull request #12132: [FLINK-17593][Connectors/FileSystem] Support arbitrary recovery mechanism for PartFileWriter

kl0u commented on pull request #12132: URL: https://github.com/apache/flink/pull/12132#issuecomment-630081189 @guoweiM did you manage to have a look at the renamings? This is an automated message from the Apache Git Service.

[GitHub] [flink] kl0u commented on pull request #12132: [FLINK-17593][Connectors/FileSystem] Support arbitrary recovery mechanism for PartFileWriter

kl0u commented on pull request #12132: URL: https://github.com/apache/flink/pull/12132#issuecomment-630047870 Hi, these are some comments with renamings and moving classes for consistency https://github.com/kl0u/flink/tree/FLINK-17593-comments. Please check them out. Probably we can

[GitHub] [flink] kl0u commented on pull request #12132: [FLINK-17593][Connectors/FileSystem] Support arbitrary recovery mechanism for PartFileWriter

kl0u commented on pull request #12132: URL: https://github.com/apache/flink/pull/12132#issuecomment-629626868 Hi @guoweiM , I am proposing to name the factory `BucketWriter`, not `BulkWriter` :) (I also get confused). The reason for this is because it does not only create `InProgress