[GitHub] [flink] kl0u commented on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'

2020-10-13 Thread GitBox
kl0u commented on pull request #13558: URL: https://github.com/apache/flink/pull/13558#issuecomment-707548093 Hi @guoweiM ! Could you rebase this PR on the current master and then I will merge. Feel free of course to squash the commits here into a single commit. --

[GitHub] [flink] kl0u commented on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'

2020-10-09 Thread GitBox
kl0u commented on pull request #13558: URL: https://github.com/apache/flink/pull/13558#issuecomment-705439346 Yes @guoweiM and @gaoyunhaii the `PartitionTransformation` javadoc is wrong and it is copied (I think) in many transformations. Actually I refactor it as part of this PR https://gi

[GitHub] [flink] kl0u commented on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'

2020-10-08 Thread GitBox
kl0u commented on pull request #13558: URL: https://github.com/apache/flink/pull/13558#issuecomment-705439346 Yes @guoweiM and @gaoyunhaii the `PartitionTransformation` javadoc is wrong and it is copied (I think) in many transformations. Actually I refactor it as part of this PR https://gi