[GitHub] [flink] klion26 commented on pull request #11722: [FLINK-5763][state backends] Make savepoints self-contained and relocatable

2020-05-16 Thread GitBox
klion26 commented on pull request #11722: URL: https://github.com/apache/flink/pull/11722#issuecomment-629731842 @StephanEwen thanks a lot for the follow-up pr and merging. I learned a lot from the follow-up pr that can be used in future contributions.

[GitHub] [flink] klion26 commented on pull request #11722: [FLINK-5763][state backends] Make savepoints self-contained and relocatable

2020-05-15 Thread GitBox
klion26 commented on pull request #11722: URL: https://github.com/apache/flink/pull/11722#issuecomment-629592972 @StephanEwen thanks for your great work. the rework(introduce a context to extract exclusive directory) is better for future expansion. the new pr LGTM. For the first

[GitHub] [flink] klion26 commented on pull request #11722: [FLINK-5763][state backends] Make savepoints self-contained and relocatable

2020-05-15 Thread GitBox
klion26 commented on pull request #11722: URL: https://github.com/apache/flink/pull/11722#issuecomment-629182391 @StephanEwen sorry, but I can't remember clearly what the problems are, I tried to find the Travis build histories, but didn't find out the problems. I'll try to recover the

[GitHub] [flink] klion26 commented on pull request #11722: [FLINK-5763][state backends] Make savepoints self-contained and relocatable

2020-05-15 Thread GitBox
klion26 commented on pull request #11722: URL: https://github.com/apache/flink/pull/11722#issuecomment-629148256 @StephanEwen If I remember correctly, this will cause some problems in my previous implementation. And we don't need to enable local recovery for savepoints

[GitHub] [flink] klion26 commented on pull request #11722: [FLINK-5763][state backends] Make savepoints self-contained and relocatable

2020-04-30 Thread GitBox
klion26 commented on pull request #11722: URL: https://github.com/apache/flink/pull/11722#issuecomment-621724165 kindly ping @StephanEwen This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] klion26 commented on pull request #11722: [FLINK-5763][state backends] Make savepoints self-contained and relocatable

2020-04-25 Thread GitBox
klion26 commented on pull request #11722: URL: https://github.com/apache/flink/pull/11722#issuecomment-619374656 @StephanEwen I've updated the pr according to the comments. please take anther round riview when you're free Currently, just convert to `RelativeStateHandle` when the