[GitHub] [flink] lincoln-lil commented on pull request #21219: [FLINK-29849][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

2022-12-18 Thread GitBox
lincoln-lil commented on PR #21219: URL: https://github.com/apache/flink/pull/21219#issuecomment-1356937839 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] lincoln-lil commented on pull request #21219: [FLINK-29849][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

2022-12-18 Thread GitBox
lincoln-lil commented on PR #21219: URL: https://github.com/apache/flink/pull/21219#issuecomment-1356805211 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] lincoln-lil commented on pull request #21219: [FLINK-29849][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

2022-12-18 Thread GitBox
lincoln-lil commented on PR #21219: URL: https://github.com/apache/flink/pull/21219#issuecomment-1356767872 @godfreyhe I've updated the pr and tried to add a new rule EventTimeTemporalJoinRewriteRule to replace the previous shuttle implementation and improved the error msg. Just simply

[GitHub] [flink] lincoln-lil commented on pull request #21219: [FLINK-29849][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

2022-12-05 Thread GitBox
lincoln-lil commented on PR #21219: URL: https://github.com/apache/flink/pull/21219#issuecomment-1338516784 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] lincoln-lil commented on pull request #21219: [FLINK-29849][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

2022-11-06 Thread GitBox
lincoln-lil commented on PR #21219: URL: https://github.com/apache/flink/pull/21219#issuecomment-1304978130 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] lincoln-lil commented on pull request #21219: [FLINK-29849][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

2022-11-06 Thread GitBox
lincoln-lil commented on PR #21219: URL: https://github.com/apache/flink/pull/21219#issuecomment-1304780562 @JingGe thank you for reviewing this! I've updated the pr according to your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] lincoln-lil commented on pull request #21219: [FLINK-29849][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

2022-11-02 Thread GitBox
lincoln-lil commented on PR #21219: URL: https://github.com/apache/flink/pull/21219#issuecomment-1301554180 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific