[GitHub] [flink] lirui-apache commented on pull request #11876: [FLINK-17334] HIVE UDF BUGFIX

2020-04-26 Thread GitBox
lirui-apache commented on pull request #11876: URL: https://github.com/apache/flink/pull/11876#issuecomment-619525993 @Ruan-Xin Thanks for the update. Some suggestions about the current PR: 1. Please make sure to follow flink's code style which will be verified by the CI system. You can

[GitHub] [flink] lirui-apache commented on pull request #11876: [FLINK-17334] HIVE UDF BUGFIX

2020-04-23 Thread GitBox
lirui-apache commented on pull request #11876: URL: https://github.com/apache/flink/pull/11876#issuecomment-618788643 @Ruan-Xin I meant you can change `HiveSimpleUDF::getHiveResultType` to something like this: ``` @Override public DataType getHiveResultType(Object[]