lirui-apache commented on pull request #16037:
URL: https://github.com/apache/flink/pull/16037#issuecomment-912297884
Thanks @wuchong for taking care of this :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
lirui-apache commented on pull request #16037:
URL: https://github.com/apache/flink/pull/16037#issuecomment-851855563
The copied code is formatted by spotless. Perhaps I should disable spotless
for this module, so that we can easily compare the diff between copied and
original hive files?
lirui-apache commented on pull request #16037:
URL: https://github.com/apache/flink/pull/16037#issuecomment-851876610
@twalthr I have split the commits and disabled spotless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
lirui-apache commented on pull request #16037:
URL: https://github.com/apache/flink/pull/16037#issuecomment-851880713
@LadyForest I think you also maintain some changes in a private hive fork.
Let me know if you want to incorporate anything else in this PR.
--
This is an automated messag
lirui-apache commented on pull request #16037:
URL: https://github.com/apache/flink/pull/16037#issuecomment-852829778
> > @LadyForest, I think you also maintain some changes in a private hive
fork. Let me know if you want to incorporate anything else in this PR.
>
> I'm just wonderin