[GitHub] [flink] lirui-apache commented on pull request #17245: [FLINK-23316][Table SQL/Ecosystem] Add tests for custom PartitionCommitPolicy

2021-09-25 Thread GitBox
lirui-apache commented on pull request #17245: URL: https://github.com/apache/flink/pull/17245#issuecomment-927218964 Thanks @JackWangCS for updating, LGTM. Please take a look at the CI failure. Alternatively, if your own azure pipeline has passed, please post the link here. Either way, we

[GitHub] [flink] lirui-apache commented on pull request #17245: [FLINK-23316][Table SQL/Ecosystem] Add tests for custom PartitionCommitPolicy

2021-09-15 Thread GitBox
lirui-apache commented on pull request #17245: URL: https://github.com/apache/flink/pull/17245#issuecomment-919998104 Thanks @JackWangCS for your contribution. My suggestion is to add a dedicated test for the custom commit policy, rather than updating existing test cases. cc @wuchong @l