[GitHub] [flink] liuyongvs commented on pull request #21958: [FLINK-31118][table] Add ARRAY_UNION function.

2023-04-25 Thread via GitHub
liuyongvs commented on PR #21958: URL: https://github.com/apache/flink/pull/21958#issuecomment-1521398415 hi @snuyanzin the pr i submit before do not think about implicit cast like spark such as ARRAY ARRAY and i sumit a new pr here https://github.com/apache/flink/pull/22483 and i

[GitHub] [flink] liuyongvs commented on pull request #21958: [FLINK-31118][table] Add ARRAY_UNION function.

2023-02-17 Thread via GitHub
liuyongvs commented on PR #21958: URL: https://github.com/apache/flink/pull/21958#issuecomment-1434909262 > Thanks for your contribution. > > To be honest i didn't get the logic. What i did: > > 1. Built it from the PR's branch > 2. Started standalone Flink > 3. Via

[GitHub] [flink] liuyongvs commented on pull request #21958: [FLINK-31118][table] Add ARRAY_UNION function.

2023-02-17 Thread via GitHub
liuyongvs commented on PR #21958: URL: https://github.com/apache/flink/pull/21958#issuecomment-1434905063 > ```sql > SELECT array_union(array[1], array[array[1, 2, 3]]); > ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] liuyongvs commented on pull request #21958: [FLINK-31118][table] Add ARRAY_UNION function.

2023-02-17 Thread via GitHub
liuyongvs commented on PR #21958: URL: https://github.com/apache/flink/pull/21958#issuecomment-1434394315 hi @snuyanzin do you have time to review it. and the input args type should do somethinh like calcite array_concat. do you have good idea, because it should be reuse like