[GitHub] [flink] lsyldliu commented on a diff in pull request #20252: [FLINK-28463][flink-sql-parser] Flink dialect supports CREATE TABLE AS SELECT(CTAS) syntax

2022-07-22 Thread GitBox
lsyldliu commented on code in PR #20252: URL: https://github.com/apache/flink/pull/20252#discussion_r927563895 ## flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl: ## @@ -1151,9 +1152,13 @@ SqlCreate SqlCreateTable(Span s, boolean replace, boolean isTempor

[GitHub] [flink] lsyldliu commented on a diff in pull request #20252: [FLINK-28463][flink-sql-parser] Flink dialect supports CREATE TABLE AS SELECT(CTAS) syntax

2022-07-21 Thread GitBox
lsyldliu commented on code in PR #20252: URL: https://github.com/apache/flink/pull/20252#discussion_r927222651 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTableAs.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [flink] lsyldliu commented on a diff in pull request #20252: [FLINK-28463][flink-sql-parser] Flink dialect supports CREATE TABLE AS SELECT(CTAS) syntax

2022-07-16 Thread GitBox
lsyldliu commented on code in PR #20252: URL: https://github.com/apache/flink/pull/20252#discussion_r922646290 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java: ## @@ -76,6 +76,8 @@ public class SqlCreateTable extends SqlCreate im