[GitHub] [flink] lsyldliu commented on a diff in pull request #20365: [FLINK-26929][table-runtime] Introduce adaptive hash join for batch hash join

2022-08-05 Thread GitBox
lsyldliu commented on code in PR #20365: URL: https://github.com/apache/flink/pull/20365#discussion_r939466103 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/HashJoinOperator.java: ## @@ -214,16 +276,121 @@ void collect(RowData row

[GitHub] [flink] lsyldliu commented on a diff in pull request #20365: [FLINK-26929][table-runtime] Introduce adaptive hash join for batch hash join

2022-08-05 Thread GitBox
lsyldliu commented on code in PR #20365: URL: https://github.com/apache/flink/pull/20365#discussion_r939466103 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/HashJoinOperator.java: ## @@ -214,16 +276,121 @@ void collect(RowData row

[GitHub] [flink] lsyldliu commented on a diff in pull request #20365: [FLINK-26929][table-runtime] Introduce adaptive hash join for batch hash join

2022-08-05 Thread GitBox
lsyldliu commented on code in PR #20365: URL: https://github.com/apache/flink/pull/20365#discussion_r939465887 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/util/JoinUtil.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundati