[GitHub] [flink] luoyuxia commented on pull request #20211: [FLINK-28451][hive] Use UserCodeClassloader instead of the current thread's classloader to load function

2022-07-22 Thread GitBox
luoyuxia commented on PR #20211: URL: https://github.com/apache/flink/pull/20211#issuecomment-1192481882 > LGTM. I have appended a commit to fix a minor problem. If you don't have concerns, I will merge it when CI passed. Thanks. That's fine. I rebased master and fix the compile error

[GitHub] [flink] luoyuxia commented on pull request #20211: [FLINK-28451][hive] Use UserCodeClassloader instead of the current thread's classloader to load function

2022-07-22 Thread GitBox
luoyuxia commented on PR #20211: URL: https://github.com/apache/flink/pull/20211#issuecomment-1192402658 > I think the existing tests are not enough. Actually, this pull request is to fix a bug that the HiveFunctionFactory uses the wrong classloader. A bug means there will be exceptions und

[GitHub] [flink] luoyuxia commented on pull request #20211: [FLINK-28451][hive] Use UserCodeClassloader instead of the current thread's classloader to load function

2022-07-21 Thread GitBox
luoyuxia commented on PR #20211: URL: https://github.com/apache/flink/pull/20211#issuecomment-1191467860 > Does this pull request also address [FLINK-28430](https://issues.apache.org/jira/browse/FLINK-28430)? Yes, I forget to link it. Now, I have closed [FLINK-28430](https://issues.

[GitHub] [flink] luoyuxia commented on pull request #20211: [FLINK-28451][hive] Use UserCodeClassloader instead of the current thread's classloader to load function

2022-07-20 Thread GitBox
luoyuxia commented on PR #20211: URL: https://github.com/apache/flink/pull/20211#issuecomment-1190972490 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.